Re: Patch for SonarQube code scan fixes.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for SonarQube code scan fixes.
Date: 2020-08-03 07:49:11
Message-ID: CANxoLDe2pKhWsXAyo2LCn+iiMHqtJQkQY57jeXz3MBRvRvUcAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Jul 31, 2020 at 6:35 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. Utils Route:
>
> - Refactor this function to reduce its Cognitive Complexity from 16 to
> the 15 allowed.
>
> 2. User Management:
>
> - Refactor this function to reduce its Cognitive Complexity from 16 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed.
>
> 3. Query tool preferences:
>
> - Merge these implicitly concatenated strings; or did you forget a
> comma?
>
> 4. Tool Maintenance:
>
> - Refactor this function to reduce its Cognitive Complexity from 16 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 20 to
> the 15 allowed.
>
>
> Regards,
> Nikhil Mohite.
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-03 07:49:21 Re: [pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects
Previous Message Akshay Joshi 2020-08-03 07:49:04 Re: [pgAdmin][SonarQube] Fixes for 13 rules.