Re: Regarding feature #642

Hi Hackers,

I have implemented feature #642 as follows.
1. If the user selects the schema node from the tree, it will use *--schema*
to take a backup of that schema. (This is only when the user selects the
schema node)
[image: image.png]
2. If a user selects a few nodes from the tree, like tables it will
partially select the schema node and it will use the *--table* to take a
backup of the selected nodes.
[image: image.png]
3. If the user selects all children of a schema but not the schema node
then it will partially select the schema node and will use the *--table *to
take a backup of the selected nodes.
[image: image.png]

Please let me know if you have any questions/ suggestions.

On Tue, Jul 4, 2023 at 10:30 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

>
>
> On Mon, Jul 3, 2023 at 6:16 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> I am currently working on #642
>> <https://github.com/pgadmin-org/pgadmin4/issues/642> to allow to
>> selection/deselect of objects under the object backup operation.
>>
>> This will be only applicable to the database and its sub-nodes(Not for
>> Backup Global and Backup server)
>>
>> Details:
>>
>> 1. Added a new tab in the backup dialog '*Objects*'
>> 2. On the '*Objects*' tab it will list down all the schemas and
>> tables under the selected database.
>> 3. [image: image.png]
>>
>> The second tab name (Data/Objects) should be changed because the last tab
> is named Objects.
>
>>
>> 1.
>> 2. If the user selects the specific Schema then it will list down
>> only tables under the selected schema.
>> 3. [image: Screenshot 2023-07-03 at 4.38.26 PM copy.png]
>> 4. By default, all the nodes from the tree will be selected and the
>> user can deselect them if required.
>>
>> +1
>
>>
>> 1. If the user de-selects all the nodes and took a backup it will
>> take a normal backup and all other nodes will get included in the backup.
>>
>> Then, selecting all the tree objects by default will make no sense.
>
>> Questions:
>>
>> 1. pgAdmin III use to support taking backup of tables only from the
>> UI, a user was not able to select views, materialized views, foreign
>> tables, and sequences from the backup dialog. (If the user selects all from
>> the checkbox on the UI then other database objects are included implicitly
>> in the backup)
>> 2. Should we continue with the above behavior or should we now allow
>> the user to select these database objects in the backup dialog?
>>
>>
>> Please let me know your suggestions/thoughts.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Senior Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>
Regards,
Nikhil Mohite