Patch for SonarQube code scan fixes.

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Patch for SonarQube code scan fixes.
Date: 2020-08-17 05:46:47
Message-ID: CAOBg0AO9x1D6W1QO3e98cxy5Y-AuP3b__AaGEZ4yGiELcjSmfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. languages:

- Refactor this function to reduce its Cognitive Complexity from 33 to
the 15 allowed.

2. foreign table:

- Refactor this function to reduce its Cognitive Complexity from 73 to
the 15 allowed.

3. schema_diff_utils:

- Refactor this function to reduce its Cognitive Complexity from 30 to
the 15 allowed.

4. schema utils:

- Refactor this function to reduce its Cognitive Complexity from 23 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 38 to
the 15 allowed.

5. schema views:

- Refactor this function to reduce its Cognitive Complexity from 18 to
the 15 allowed.

6. schema diff directory_compare:

- Refactor this function to reduce its Cognitive Complexity from 54 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.

Attachment Content-Type Size
SonarQubeCodeSmellFixes.patch application/octet-stream 38.7 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-17 06:05:25 pgAdmin 4 commit: Update Japanese translation.
Previous Message Aditya Toshniwal 2020-08-17 04:06:46 Re: please add improvement in restoration tasks