From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for SonarQube code scan fixes. |
Date: | 2020-08-19 08:14:06 |
Message-ID: | CANxoLDcgZ4X05NoqaxUQCS0Sg8HxRc+adaMNbR9=6T2N3pyLUQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Aug 17, 2020 at 11:17 AM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. languages:
>
> - Refactor this function to reduce its Cognitive Complexity from 33 to
> the 15 allowed.
>
> 2. foreign table:
>
> - Refactor this function to reduce its Cognitive Complexity from 73 to
> the 15 allowed.
>
> 3. schema_diff_utils:
>
> - Refactor this function to reduce its Cognitive Complexity from 30 to
> the 15 allowed.
>
> 4. schema utils:
>
> - Refactor this function to reduce its Cognitive Complexity from 23 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 38 to
> the 15 allowed.
>
> 5. schema views:
>
> - Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed.
>
> 6. schema diff directory_compare:
>
> - Refactor this function to reduce its Cognitive Complexity from 54 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 16 to
> the 15 allowed.
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-19 08:14:19 | Re: [pgAdmin4][Patch] - SonarQube Issues - 14 (String literals should not be duplicated, Cognitive Complexity of functions should not be too high) |
Previous Message | Akshay Joshi | 2020-08-19 08:13:21 | pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu |