Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to Flask-Babel >= 2.0

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to Flask-Babel >= 2.0
Date: 2020-12-30 06:59:42
Message-ID: CAOBg0ANfoqdkRh1L8Q8NeDmm_ktTNP6+=Bxx2dXg=eh_=idLdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Team,

I found one issue related to Flask-Babel migration.

Flask-Babel and Flask-BabelEx are causing the issue if we install them in
the same environment.
Flask-BabelEx gets installed as a dependency of Flask-Security-Too library
and currently, Flask-Security-Too doesn’t support Flask-Babel, but the
latest version (4.0 Not yet released) of Flask-Security-Too will shift to
Flask-Babel.
ref: https://github.com/Flask-Middleware/flask-security/issues/353

So I think we should hold Flask-Babel migration for now. but we can update
the FLask-BabelEx to the latest version as there is one issue related to it
this https://redmine.postgresql.org/issues/5997
<https://redmine.postgresql.org/issues/5997> we can fix it first by adding
the Flask-BabelEx minimum version in our requirements.

Regards,
Nikhil Mohite.

On Tue, Dec 29, 2020 at 4:36 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Team,
>
> Please find the attached patch for RM-6088
> <https://redmine.postgresql.org/issues/6088>: Migrate pgadmin4 from
> Flask-BabelEx to Flask-Babel >= 2.0.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2020-12-30 10:45:29 [pgAdmin][RM-5997]: Incorrect Flask-BabelEx version in requirements for pgAdmin 4.28.
Previous Message Akshay Joshi 2020-12-30 06:55:38 Re: [pgAdmin][RESQL]: Fix for column RESQL test cases.