Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to Flask-Babel >= 2.0

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to Flask-Babel >= 2.0
Date: 2020-12-31 09:53:18
Message-ID: CAFOhELcgb8_-QqwJe1a=zgE+z5dRvHF-CoSU7O5gMmC1KkQAwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Dec 30, 2020 at 12:29 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Team,
>
> I found one issue related to Flask-Babel migration.
>
> Flask-Babel and Flask-BabelEx are causing the issue if we install them in
> the same environment.
> Flask-BabelEx gets installed as a dependency of Flask-Security-Too library
> and currently, Flask-Security-Too doesn’t support Flask-Babel, but the
> latest version (4.0 Not yet released) of Flask-Security-Too will shift to
> Flask-Babel.
> ref: https://github.com/Flask-Middleware/flask-security/issues/353
>
> So I think we should hold Flask-Babel migration for now. but we can update
> the FLask-BabelEx to the latest version as there is one issue related to it
> this https://redmine.postgresql.org/issues/5997
> <https://redmine.postgresql.org/issues/5997> we can fix it first by
> adding the Flask-BabelEx minimum version in our requirements.
>
>
> +1

>
> Regards,
> Nikhil Mohite.
>
> On Tue, Dec 29, 2020 at 4:36 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch for RM-6088
>> <https://redmine.postgresql.org/issues/6088>: Migrate pgadmin4 from
>> Flask-BabelEx to Flask-Babel >= 2.0.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2021-01-01 07:05:22 Re: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake
Previous Message Akshay Joshi 2020-12-31 08:25:47 Re: Housekeeping #5338 - [Code Coverage] Improve API test cases for pgAgent