| From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Patch for SonarQube code scan fixes |
| Date: | 2020-11-10 10:13:41 |
| Message-ID: | CAOBg0AMfrrmXuSx6ZrPPMWgq2GHNNEc-LvekTutKt25fKHj-FQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Team,
I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Schema dif dependency:
- 'isChecked' is already declared in the upper scope.
2. User management:
- Refactor this function to reduce its Cognitive Complexity from 27 to
the 15 allowed.
3. Debugger:
- Refactor this function to reduce its Cognitive Complexity from 30 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 45 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 50 to
the 15 allowed.
--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/>
*Mob.No: +91-7798364578.*
| Attachment | Content-Type | Size |
|---|---|---|
| SonarQubeCodeSmellFixes.patch | application/octet-stream | 23.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2020-11-10 13:22:37 | [pgAdmin4] Enhance the Schema diff GUI validation |
| Previous Message | Rahul Shirsat | 2020-11-10 08:29:32 | Re: SonarQube Fixes #3 |