From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for SonarQube code scan fixes |
Date: | 2020-11-12 12:39:49 |
Message-ID: | CANxoLDcg4Czh51o6-g25k=6eR+hMcKwwG5WNT15MK-C2j1+sYg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Nov 10, 2020 at 3:44 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. Schema dif dependency:
>
> - 'isChecked' is already declared in the upper scope.
>
> 2. User management:
>
> - Refactor this function to reduce its Cognitive Complexity from 27 to
> the 15 allowed.
>
> 3. Debugger:
>
> - Refactor this function to reduce its Cognitive Complexity from 30 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 45 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 50 to
> the 15 allowed.
>
>
>
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-11-12 12:40:29 | Re: [pgAdmin][RM-5983]:Add server type icon on new connection dialog. |
Previous Message | Akshay Joshi | 2020-11-12 12:39:34 | Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed |