From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org> |
Subject: | Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires. |
Date: | 2021-01-14 12:28:00 |
Message-ID: | CAOBg0AMPK7rCfXLykF+1JX_+DVq31TON+G01bpzs69aPTs7QEg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please find the updated patch, updated UI to allow users to select an older
date for the account expires.
Regards,
Nikhil Mohite.
On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Nikhil
>
> On Thu, Jan 14, 2021 at 2:38 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <
>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> Please find the attached patch for RM-6120
>>>> <https://redmine.postgresql.org/issues/6120>: Adding/updating user
>>>> should not allow to add an older date in account expires.
>>>> Added UI validation if a user enters the account expiration date
>>>> manually.
>>>>
>>>
>> I think this needs to be reverted (and the UI fixed to allow an older
>> date to be selected).
>>
>
> Please fixed as suggested by Dave and send the patch. I'll update the
> RM
>
>>
>> Selecting a past expiry date is a perfectly valid way to create an
>> account that is effectively locked, for example, to allow pre-creation of
>> roles for staff that are yet to join.
>>
>> PostgreSQL doesn't prevent this - why should we?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
RM_6120_v2.patch | application/octet-stream | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pradip Parkale | 2021-01-14 13:28:34 | Re: [pgAdmin][RM5912]: Added support for Logical Replication. |
Previous Message | Akshay Joshi | 2021-01-14 12:18:58 | Re: [pgAdmin][RM5912]: Added support for Logical Replication. |