Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.
Date: 2021-01-14 09:22:08
Message-ID: CANxoLDeHgFxMRBAg++3mLkGmFjDwJPKqBNz3wkhK99+rq86N8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Nikhil

On Thu, Jan 14, 2021 at 2:38 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the attached patch for RM-6120
>>> <https://redmine.postgresql.org/issues/6120>: Adding/updating user
>>> should not allow to add an older date in account expires.
>>> Added UI validation if a user enters the account expiration date
>>> manually.
>>>
>>
> I think this needs to be reverted (and the UI fixed to allow an older date
> to be selected).
>

Please fixed as suggested by Dave and send the patch. I'll update the RM

>
> Selecting a past expiry date is a perfectly valid way to create an account
> that is effectively locked, for example, to allow pre-creation of roles for
> staff that are yet to join.
>
> PostgreSQL doesn't prevent this - why should we?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Pramod Ahire 2021-01-14 11:24:05 Quick search for menu items & help articles
Previous Message Akshay Joshi 2021-01-14 09:18:32 pgAdmin 4 commit: Revert "Ensure that the account expiration date for r