Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Date: 2020-08-20 12:01:36
Message-ID: CAOBg0AM8coLjoYL6kUirbo+5cmm9VhqXp0SH_FgRyzekBaPOtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave/Team,

I have updated the style guide as per the suggestions, PFA of the updated
patch for the same.

On Thu, Aug 20, 2020 at 1:37 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave/Team,
>>
>> As per discussion with the UX team, Few updates on style-guide patch.
>> 1. I have missed removing the "proposed" keyword from the "High-Contract"
>> theme name.
>>
> 1. Removed "proposed" keyword from the "High-Contrast" theme name.

>
> Right.
>
>
>> 2. I have not added the "Writing Style" section in the style guide as we
>> don’t have the information for it (UX design is also pending due to this). @Dave
>> Page <dave(dot)page(at)enterprisedb(dot)com> can you provide some inputs on it.
>>
>
> Sure; not sure how to deal with that yet - we'll proceed without it for
> now.
>
> A couple of other issues I found:
>
> - Random scrollbars:
>
> [image: Screenshot 2020-08-20 at 09.00.38.png]
>
2. Resolved scrollbar issue.

>
> - On the Menu section, there is a subsection for "Sub menus" (I realise
> you didn't design that, but...). That doesn't seem right; what is described
> as a sub menu there is actually a tab set. Can you move it to a separate
> section please?
>
3. Create a new section for "Tab Set" as suggested.

>
> There are a few wording changes I'd like as well, but I can deal with that
> when I'm committing.
>
> Nice work - thanks!
>
>
>>
>> Regards,
>> Nikhil Mohite.
>>
>> On Wed, Aug 19, 2020 at 11:40 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> I have updated the style guide for the pgAdmin 4 website as per RM-5990
>>> <https://redmine.postgresql.org/issues/5690>.
>>> Details :
>>> 1. The updated style-guide section as per the new UI design.
>>> 2. Added new icons as per font-awesome 5.14.0.
>>> 3. Added custom icons of pgAdmin4.
>>>
>>> PFA the patch.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

Attachment Content-Type Size
RM_5690_v2.patch application/octet-stream 6.2 MB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-20 12:50:03 pgAdmin 4 v4.25 released
Previous Message Rahul Shirsat 2020-08-20 11:17:00 Re: [pgAdmin4][Patch] - SonarQube Fixes #2