From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website |
Date: | 2020-08-20 08:07:42 |
Message-ID: | CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
> Hi Dave/Team,
>
> As per discussion with the UX team, Few updates on style-guide patch.
> 1. I have missed removing the "proposed" keyword from the "High-Contract"
> theme name.
>
Right.
> 2. I have not added the "Writing Style" section in the style guide as we
> don’t have the information for it (UX design is also pending due to this). @Dave
> Page <dave(dot)page(at)enterprisedb(dot)com> can you provide some inputs on it.
>
Sure; not sure how to deal with that yet - we'll proceed without it for now.
A couple of other issues I found:
- Random scrollbars:
[image: Screenshot 2020-08-20 at 09.00.38.png]
- On the Menu section, there is a subsection for "Sub menus" (I realise
you didn't design that, but...). That doesn't seem right; what is described
as a sub menu there is actually a tab set. Can you move it to a separate
section please?
There are a few wording changes I'd like as well, but I can deal with that
when I'm committing.
Nice work - thanks!
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Aug 19, 2020 at 11:40 AM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> I have updated the style guide for the pgAdmin 4 website as per RM-5990
>> <https://redmine.postgresql.org/issues/5690>.
>> Details :
>> 1. The updated style-guide section as per the new UI design.
>> 2. Added new icons as per font-awesome 5.14.0.
>> 3. Added custom icons of pgAdmin4.
>>
>> PFA the patch.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-20 08:34:39 | pgAdmin 4 commit: Improve code coverage and API test cases for Grant Wi |
Previous Message | Nikhil Mohite | 2020-08-19 09:20:20 | Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website |