Re: Checksum errors in pg_stat_database

On Fri, Feb 22, 2019 at 3:25 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Fri, Feb 22, 2019 at 3:23 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>
>>
>>
>> On Fri, Feb 22, 2019 at 3:16 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>>
>>> On Fri, Feb 22, 2019 at 3:01 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> >
>>> > PFA is a patch to do this.
>>>
>>> +void
>>> +pgstat_report_checksum_failure(void)
>>> +{
>>> + PgStat_MsgDeadlock msg;
>>>
>>> I think that you meant PgStat_MsgChecksumFailure :)
>>>
>>> +/* ----------
>>> + * pgstat_recv_checksum_failure() -
>>> + *
>>> + * Process a DEADLOCK message.
>>> + * ----------
>>>
>>> same here
>>>
>>> Otherwise LGTM.
>>
>>
>> Haha, damit, that's embarassing. You can probably guess where I copy/pasted from :)

heh :)

>>
>
> And of course, then I forgot to attach the new file.

It all looks fine. One minor nitpicking issue I just noticed, there's
an extra space there:

+ dbentry->n_checksum_failures ++;

I'm marking it as ready for committer!