Re: Checksum errors in pg_stat_database

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Checksum errors in pg_stat_database
Date: 2019-02-22 14:24:52
Message-ID: CABUevEwJ8i7=aY_oukJN-9m5PSk6A3vR+Ko+81JG01QKqWnpRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 22, 2019 at 3:23 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:

>
>
> On Fri, Feb 22, 2019 at 3:16 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
>> On Fri, Feb 22, 2019 at 3:01 PM Magnus Hagander <magnus(at)hagander(dot)net>
>> wrote:
>> >
>> > PFA is a patch to do this.
>>
>> +void
>> +pgstat_report_checksum_failure(void)
>> +{
>> + PgStat_MsgDeadlock msg;
>>
>> I think that you meant PgStat_MsgChecksumFailure :)
>>
>> +/* ----------
>> + * pgstat_recv_checksum_failure() -
>> + *
>> + * Process a DEADLOCK message.
>> + * ----------
>>
>> same here
>>
>> Otherwise LGTM.
>>
>
> Haha, damit, that's embarassing. You can probably guess where I
> copy/pasted from :)
>
>
And of course, then I forgot to attach the new file.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Attachment Content-Type Size
stat_checksums2.patch text/x-patch 8.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-02-22 14:29:41 Re: Unnecessary checks for new rows by some RI trigger functions?
Previous Message Magnus Hagander 2019-02-22 14:23:54 Re: Checksum errors in pg_stat_database