| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, noah(at)leadboat(dot)com |
| Subject: | Re: reindexdb & clusterdb broken against pre-7.3 servers |
| Date: | 2019-05-06 15:31:17 |
| Message-ID: | CAOBaU_Yra0iFrJpCt+kL1ZKYKuHbU8yqnLpeBMy7LXJ15pJG5w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 6, 2019 at 3:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Mon, May 06, 2019 at 08:32:44AM -0400, Andrew Dunstan wrote:
> >> Why do we even have code referring to pre-7.3 servers? Wouldn't it be
> >> simpler just to remove that code?
>
> > Even for pg_dump, we only support servers down to 8.0. Let's nuke
> > this code.
>
> +1. I think psql claims to support down to 7.4, but that's still not
> a precedent for trying to handle pre-7.3. Also, the odds that we'd
> not break this code path again in future seem pretty bad.
WFM. Updated patch attached, I also removed another similar chunk in
the same file while at it.
| Attachment | Content-Type | Size |
|---|---|---|
| fix_appendQualifiedRelation-v3.diff | application/octet-stream | 765 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-05-06 15:34:24 | Re: reindexdb & clusterdb broken against pre-7.3 servers |
| Previous Message | Robert Haas | 2019-05-06 15:29:10 | Re: POC: Cleaning up orphaned files using undo logs |