Re: reindexdb & clusterdb broken against pre-7.3 servers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, noah(at)leadboat(dot)com
Subject: Re: reindexdb & clusterdb broken against pre-7.3 servers
Date: 2019-05-06 15:34:24
Message-ID: 15462.1557156864@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> WFM. Updated patch attached, I also removed another similar chunk in
> the same file while at it.

Uh, that looks backwards:

@@ -146,10 +146,6 @@ connectDatabase(const char *dbname, const char *pghost,
exit(1);
}

- if (PQserverVersion(conn) >= 70300)
- PQclear(executeQuery(conn, ALWAYS_SECURE_SEARCH_PATH_SQL,
- progname, echo));
-
return conn;
}

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2019-05-06 15:39:18 Re: reindexdb & clusterdb broken against pre-7.3 servers
Previous Message Julien Rouhaud 2019-05-06 15:31:17 Re: reindexdb & clusterdb broken against pre-7.3 servers