From: | navnath gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP] |
Date: | 2020-03-17 10:06:47 |
Message-ID: | CAOAJCYq+4hzqtVCMTUD-CyEYwdj-NS-ZvuabUx0_AL3FUXiMKw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Khushboo,
I think there is no use of
+ if app is not None:
+ AuthSourceRegistry.load_auth_sources()
+
in get_auth_sources() function.
On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch to support LDAP Authentication in Server
> mode.
> To test the patch, config_auth.py needs to be configured for LDAP
> configurations. The config settings are explained in this file in detail.
> After configuring the parameters, start the pgadmin server in Server mode
> and connect with LDAP server with the valid user via login page.
>
> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
> have used the default config of ldap3 without certificates.
>
> @Dave, can you please review this patch, as you have a better
> understanding of LDAP and you can easily pointed out if I have missed
> anything.
>
> Note: For the document update I will create the task and assign to Nidhi
> for the same.
>
> Thanks,
> Khushboo
>
--
*-- Navnath*
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2020-03-17 10:12:01 | Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP] |
Previous Message | Khushboo Vashi | 2020-03-17 08:55:38 | [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP] |