Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi Navnath,

On Tue, Mar 17, 2020 at 3:37 PM navnath gadakh <
navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:

> Hi Khushboo,
> I think there is no use of
>
> + if app is not None:
> + AuthSourceRegistry.load_auth_sources()
> +
>
> in get_auth_sources() function.
>
> Thanks for the review, I will look into it.

Thanks,
Khushboo

>
> On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to support LDAP Authentication in Server
>> mode.
>> To test the patch, config_auth.py needs to be configured for LDAP
>> configurations. The config settings are explained in this file in detail.
>> After configuring the parameters, start the pgadmin server in Server mode
>> and connect with LDAP server with the valid user via login page.
>>
>> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
>> have used the default config of ldap3 without certificates.
>>
>> @Dave, can you please review this patch, as you have a better
>> understanding of LDAP and you can easily pointed out if I have missed
>> anything.
>>
>> Note: For the document update I will create the task and assign to Nidhi
>> for the same.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *-- Navnath*
>