output/security_label.source referring to abs_builddir instead of libdir

From: Hamid Quddus Akhtar <hamid(dot)quddus(at)enterprisedb(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: output/security_label.source referring to abs_builddir instead of libdir
Date: 2013-09-17 14:04:14
Message-ID: CAOA6zUySzJVgqkQ-ufbY+KwOGOvCvqVeK4S2KHZU7ut7UUo3hA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In make check, there are 4 shared libraries that are loaded for test cases
from the src/test/regress folder. Whereas, output of other libraries
contain @libdir@ tag, the output file for security_label (dumm_seclabel)
contains a tag for @abs_builddir@ in the output/security_label.source file.

I believe this an issue, and rather than referring @abs_builddir@, it
should instead contain the tag @libdir(at)(dot) Also note that while I could
provide a path for dynamic libraries via "dlpath" option of pg_regress,
this is not honored by security_label test case.

PFA patch for this fix.

Regards.

--
*
*
*Hamid Quddus Akhtar*
Configuration Management Team

Ph: +92.333.544.9950
Skype ID: EngineeredVirus
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community> and
more <http://www.enterprisedb.com/resources-community>

Attachment Content-Type Size
security_label.source.output.patch application/octet-stream 627 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-09-17 14:14:16 Re: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)
Previous Message Dimitri Fontaine 2013-09-17 13:56:46 Re: record identical operator