| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Hamid Quddus Akhtar <hamid(dot)quddus(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: output/security_label.source referring to abs_builddir instead of libdir |
| Date: | 2013-09-23 20:09:01 |
| Message-ID: | 20130923200901.GB18041@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 17, 2013 at 07:04:14PM +0500, Hamid Quddus Akhtar wrote:
> In make check, there are 4 shared libraries that are loaded for test cases
> from the src/test/regress folder. Whereas, output of other libraries
> contain @libdir@ tag, the output file for security_label (dumm_seclabel)
> contains a tag for @abs_builddir@ in the output/security_label.source file.
>
> I believe this an issue, and rather than referring @abs_builddir@, it
> should instead contain the tag @libdir(at)(dot) Also note that while I could
> provide a path for dynamic libraries via "dlpath" option of pg_regress,
> this is not honored by security_label test case.
>
> PFA patch for this fix.
More simply, if input/security_label.source says @libdir@,
output/security_label.source ought to match that. Committed.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-09-23 20:09:33 | Re: UTF8 national character data type support WIP patch and list of open issues. |
| Previous Message | Noah Misch | 2013-09-23 20:07:58 | Re: pgbench progress report improvements - split 1 |