Re: [pgAdmin][RM4873] Change comment of a procedure with arguments

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4873] Change comment of a procedure with arguments
Date: 2020-04-15 08:28:45
Message-ID: CANxoLDfySiWeMAFZJJD-gukbi=Ow_pVhZ+DhSgNRDMeo5e7MFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Apr 14, 2020 at 5:52 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is a patch to fix following issues:
> 1) Change comment of procedure with arguments as a procedure can be
> overloaded. Note that on EPAS servers, procedure overloading works only for
> v11+ .
> 2) The save button of a procedure dialog is enabled without any change.
> Fixed.
> 3) Fixed formatting of the reverse engineered SQL.
> 4) On EPAS servers, parameters set were not displayed in the SQL
> generated. They are visible only if set to edbsql. Fixed.
> 5) Changing the volatility option of any existing procedure was not
> working. Fixed.
> 6) Changing the parallel option (EPAS v9.6+) was not working. Fixed.
> 7) Added RE-SQL test cases for procedures. Fixes #4620.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-15 08:28:56 Re: [pgAdmin4 - Bug #5387]
Previous Message Akshay Joshi 2020-04-15 08:27:59 pgAdmin 4 commit: Fixed following issues for Procedures: