[pgAdmin][RM4873] Change comment of a procedure with arguments

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM4873] Change comment of a procedure with arguments
Date: 2020-04-14 12:21:27
Message-ID: CAM9w-_mDceEFJcs7FZiYhgNy1wfuHPYvRajH_Auj13BizoBwZg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is a patch to fix following issues:
1) Change comment of procedure with arguments as a procedure can be
overloaded. Note that on EPAS servers, procedure overloading works only for
v11+ .
2) The save button of a procedure dialog is enabled without any change.
Fixed.
3) Fixed formatting of the reverse engineered SQL.
4) On EPAS servers, parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql. Fixed.
5) Changing the volatility option of any existing procedure was not
working. Fixed.
6) Changing the parallel option (EPAS v9.6+) was not working. Fixed.
7) Added RE-SQL test cases for procedures. Fixes #4620.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM4873_4620.patch application/octet-stream 80.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2020-04-14 13:14:30 pgAdmin 4 commit: [Foreign Key] Removed 1 unexpected arguments; 'get_no
Previous Message Ganesh Jaybhay 2020-04-14 12:06:48 [pgAdmin][4709] Invalid FTS configuration token dictionaries