Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions
Date: 2020-07-24 06:46:52
Message-ID: CANxoLDftcn98d=wGqyCE-Q3UsR-UTT6CRZcjSxX+7WsdvuMhhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Jul 20, 2020 at 12:25 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to reduce cognitive complexity of functions:
> 1) web/.../exclusion_constraint/__init__.py > create > from 25 to 15
> 2) web/.../exclusion_constraint/__init__.py > sql > from 19 to 15
> 3) web/.../databases/schemas/utils.py > parse_vacuum_data > from 18 to 15
> 4) web/.../tools/debugger/__init__.py > initialize_target > from 37 to 15
> 5) web/.../tools/debugger/__init__.py > execute_debugger_query > from 22
> to 15
> 6) web/.../tools/debugger/__init__.py > messages > from 16 to 15
> Please review.
>
> --
> Regards,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-24 06:47:01 Re: Patch for SonarQube code scan fixes.
Previous Message Akshay Joshi 2020-07-24 06:46:43 Re: [pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)