Re: Patch for SonarQube code scan fixes.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for SonarQube code scan fixes.
Date: 2020-07-24 06:47:01
Message-ID: CANxoLDey=1EHK_EsbhaYfPQoTcmxtjBbtL3q+jSjXaabKOLw5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Jul 21, 2020 at 10:45 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
> 1. Database utils:
>
> - Refactor this function to reduce its Cognitive Complexity from 27 to
> the 15 allowed.
>
> 2. Schema views:
>
> - Refactor this function to reduce its Cognitive Complexity from 23 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 72 to
> the 15 allowed.
>
> 3. Foreign key utils:
>
> - Refactor this function to reduce its Cognitive Complexity from 39 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed.
>
> 4. Rules init:
>
> - Refactor this function to reduce its Cognitive Complexity from 20 to
> the 15 allowed.
>
> 5. Trigger init and utils:
>
> - Refactor this function to reduce its Cognitive Complexity from 16 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 34 to
> the 15 allowed.
>
>
> Regards,
> Nikhil Mohite.
>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-24 09:30:01 pgAdmin 4 commit: Fixed 'cannot unpack non-iterable Response object' is
Previous Message Akshay Joshi 2020-07-24 06:46:52 Re: [pgAdmin][SonarQube] Reduce cognitive complexity of functions