Re: [pgAdmin][RM5666]: Added missing dependencies/dependent node

Hi Aditya

On Tue, Jul 14, 2020 at 4:22 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> The partition of a table is showing an extra "Partition index" dependents,
> whereas there are no nodes under indexes node.
> The primary key displayed twice is an existing issue, confirmed with 4.23.
> [image: Screenshot 2020-07-14 at 4.02.23 PM.png]
>
> Apart from that, the patch looks good to me. Test cases success on all the
> server versions.
>

Partition Index is newly added dependent as per PostgreSQL
documentation, this index is system generated index, so we are not showing
them.
We will check whether it should be visible or not. I have committed the
code.

>
> On Tue, Jul 14, 2020 at 1:15 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> I'll be reviewing the patch.
>>
>> On Tue, Jul 14, 2020 at 12:46 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers
>>>
>>> Attached is the patch to add missing dependencies/dependent nodes
>>>
>>> Added following missing nodes:
>>>
>>> - Materialized View
>>> - Event Trigger
>>> - Collation
>>> - FTS Configuration, FTS Dictionary, FTS Parser, FTS Template,
>>> - RLS Policy
>>> - Extension
>>> - Synonyms (EPAS)
>>> - Packages (EPAS)
>>> - Compound Trigger (EPAS)
>>>
>>> Following bugs fixed with this patch:
>>>
>>> - Foreign Table is interpreted as a Foreign Data Wrapper.
>>> - Domain is interpreted as a type.
>>> - Domain constraint is interpreted as a check constraint.
>>> - Partitioned Table is interpreted as a Partition.
>>> - Trigger function is interpreted as a function in the
>>> dependencies tab for Event Triggers.
>>> - Procedure interpreted as a Function.
>>>
>>> Please review it.
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*