Re: [pgAdmin][RM5666]: Added missing dependencies/dependent node

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5666]: Added missing dependencies/dependent node
Date: 2020-07-14 10:51:23
Message-ID: CAM9w-_=PeLkF-uaasR9-XvhwRpypJs9QA+W7VT2MYyb+VuYNzQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

The partition of a table is showing an extra "Partition index" dependents,
whereas there are no nodes under indexes node.
The primary key displayed twice is an existing issue, confirmed with 4.23.
[image: Screenshot 2020-07-14 at 4.02.23 PM.png]

Apart from that, the patch looks good to me. Test cases success on all the
server versions.

On Tue, Jul 14, 2020 at 1:15 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> I'll be reviewing the patch.
>
> On Tue, Jul 14, 2020 at 12:46 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers
>>
>> Attached is the patch to add missing dependencies/dependent nodes
>>
>> Added following missing nodes:
>>
>> - Materialized View
>> - Event Trigger
>> - Collation
>> - FTS Configuration, FTS Dictionary, FTS Parser, FTS Template,
>> - RLS Policy
>> - Extension
>> - Synonyms (EPAS)
>> - Packages (EPAS)
>> - Compound Trigger (EPAS)
>>
>> Following bugs fixed with this patch:
>>
>> - Foreign Table is interpreted as a Foreign Data Wrapper.
>> - Domain is interpreted as a type.
>> - Domain constraint is interpreted as a check constraint.
>> - Partitioned Table is interpreted as a Partition.
>> - Trigger function is interpreted as a function in the
>> dependencies tab for Event Triggers.
>> - Procedure interpreted as a Function.
>>
>> Please review it.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2020-07-14 13:03:55 Re: [pgAdmin4][Patch] - SonarQube Fixes
Previous Message Akshay Joshi 2020-07-14 10:36:20 Re: [pgAdmin][SonarQube] Duplicate CSS blocks