Re: RM5049 Patch

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: RM5049 Patch
Date: 2020-01-16 09:16:43
Message-ID: CANxoLDfpYqkkcfSQTtNC77KcJweFZ+ZS6=99-FeeEbpWfk9otQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied with some modification as verify cast logic is not
working.

On Wed, Jan 15, 2020 at 2:45 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find updated patch -
>
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Wed, Jan 15, 2020 at 1:49 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Patch only covers removal of the code and change in "coveragerc.in". I
>> guess you missed to add the new files in the patch. Can you please verify ?
>>
>> Thanks,
>> Neel Patel
>>
>> On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for api tests for cast node.This covers -
>>> Added new file (cast_test_cases.json) storing inventory, test, expected
>>> data.
>>> Also covers test cases for all cast node related api,
>>> This increase code coverage for cast from 33% to 68%.
>>>
>>> Command to run tests -
>>> --pkg browser.server_groups.servers.databases.casts.tests
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-01-16 12:24:13 Re: [pgAdmin][RM5050] Language node code coverage.
Previous Message Akshay Joshi 2020-01-16 09:16:06 Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation