Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation
Date: 2020-01-16 09:16:06
Message-ID: CANxoLDfKjw6GN5ORkYB==_POq2PBuz-1xk=+NtNrwXgww7-8NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Jan 16, 2020 at 12:00 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to replace node-sass with sass for SCSS compilation,
> along with changes required in pgAdmin files. It will fix the issues
> reported by yarn audit. sass is better maintained library than node-sass.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-01-16 09:16:43 Re: RM5049 Patch
Previous Message Akshay Joshi 2020-01-16 09:15:49 pgAdmin 4 commit: Improve code coverage and API test cases for the CAST