Re: oauth2 patch

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Florian Sabonchi <sabonchi(at)posteo(dot)de>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: oauth2 patch
Date: 2021-05-10 05:29:42
Message-ID: CANxoLDfnOgg2b3FQL0fNkiDie1oUmeX5YE4EqKUR5cMQCN9kMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Khushboo

Can you please review the patch?

On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <sabonchi(at)posteo(dot)de> wrote:

> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't
> sure how the test should look like, because I couldn't find anything in
> the developer documentation, so I decided not to write one for now.
>
> The configuration has to look like this here is an example for github:
>
> OAUTH2_NAME = 'github'
> OAUTH2_CLIENT_ID = 'secret'
> OAUTH2_CLIENT_SECRET = 'secret'
> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token'
> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize'
> OAUTH2_API_BASE_URL = 'https://api.github.com/'
> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user'
> OAUTH_ENDPOINT_NAME = 'user'
>
>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2021-05-10 05:39:05 [pgAdmin 4][Patch] - Kerberos authentication phase 2 documentation
Previous Message Florian Sabonchi 2021-05-07 15:41:18 oauth2 patch