Re: oauth2 patch

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Florian Sabonchi <sabonchi(at)posteo(dot)de>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: oauth2 patch
Date: 2021-05-10 10:32:05
Message-ID: CAFOhELcOfF-GEsnuAHOLRai4aoZjw9grX=DYN1X5U8QyKUYiUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, May 10, 2021 at 10:59 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> Can you please review the patch?
>
On it.

>
> On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <sabonchi(at)posteo(dot)de>
> wrote:
>
>> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't
>> sure how the test should look like, because I couldn't find anything in
>> the developer documentation, so I decided not to write one for now.
>>
>> The configuration has to look like this here is an example for github:
>>
>> OAUTH2_NAME = 'github'
>> OAUTH2_CLIENT_ID = 'secret'
>> OAUTH2_CLIENT_SECRET = 'secret'
>> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token'
>> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize'
>> OAUTH2_API_BASE_URL = 'https://api.github.com/'
>> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user'
>> OAUTH_ENDPOINT_NAME = 'user'
>>
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2021-05-10 12:45:17 [pgAdmin][RM-2341]: Add menu option for starting PSQL
Previous Message Akshay Joshi 2021-05-10 09:58:54 pgAdmin 4 commit: Ensure that pgAdmin4 shut down completely on the Quit