From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified |
Date: | 2020-01-31 07:08:18 |
Message-ID: | CANxoLDfid6kWwA9ziDN6H4NVj+x1jyWAs1ftVJTVsFfaBFE9rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the updated patch to include dialogs (create/edit) for all the
> nodes.
> Kindly review.
>
> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> As per discussion, we should visit all the nodes create/edit dialog and
>> make the controls read-only wherever appropriate.
>>
>> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to allow input controls to be set as readonly
>>> instead of disabled.
>>> I've also changed the code for the nodes to make sure properties tab
>>> have readonly fields wherever applicable. This will allow tab navigation in
>>> properties tab and also allow screen readers to read it.
>>> Please note that, I've not visited each and every node create/edit
>>> dialog to identify what should be readonly or what should be disabled as it
>>> depends on business logic. The patch is mainly for the properties tab.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-01-31 08:52:24 | pgAdmin 4 commit: 1) Added labels and titles after parsing and validati |
Previous Message | Akshay Joshi | 2020-01-31 07:07:54 | pgAdmin 4 commit: Set input controls as read-only instead of disabled w |