Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified
Date: 2020-01-30 08:25:13
Message-ID: CAM9w-_=Qq-CLLxMPNY6t48=9ETq9kQRz7Q-+BfGZrqWTnARZaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the updated patch to include dialogs (create/edit) for all the
nodes.
Kindly review.

On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya
>
> As per discussion, we should visit all the nodes create/edit dialog and
> make the controls read-only wherever appropriate.
>
> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to allow input controls to be set as readonly
>> instead of disabled.
>> I've also changed the code for the nodes to make sure properties tab have
>> readonly fields wherever applicable. This will allow tab navigation in
>> properties tab and also allow screen readers to read it.
>> Please note that, I've not visited each and every node create/edit dialog
>> to identify what should be readonly or what should be disabled as it
>> depends on business logic. The patch is mainly for the properties tab.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM4993_v2.patch application/octet-stream 166.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-01-31 06:14:28 pgAdmin 4 commit: Set proper focus on tab navigation for file manager d
Previous Message Pradip Parkale 2020-01-29 13:11:17 [pgAdmin][RM4770] [Accessibility]Parse & validate the web pages