Re: Sonarqube fixes - test_utils.py

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Sonarqube fixes - test_utils.py
Date: 2020-08-03 07:51:41
Message-ID: CANxoLDfiEuigW9Hjiizva1WO3O5=3_mvTwRjVv7bHacovrYYJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Jul 31, 2020 at 12:07 PM Shubham Agarwal <
shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:

> Hi Team,
> Attached is the patch to fix all the Sonar Qube related errors in
> test_utils.py
>
> On Thu, Jul 30, 2020 at 4:37 PM Shubham Agarwal <
> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Murtuza,
>> I will check and send the fix.
>>
>> On Thu, Jul 30, 2020, 4:07 PM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> -- pgadmin-hackers
>>> ++ PEM
>>>
>>> Hi Shubham,
>>>
>>> Reviewed & Committed, But sonarlint is showing 7 other issues in this
>>> file apart from this bug fix.
>>>
>>> [image: image.png]
>>>
>>> On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal <
>>> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Team,
>>>> Attached is the patch containing a fix for the SonarQube Bug in the
>>>> test_utils.py file.
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Shubham Agarwal
>>>> EnterpriseDB Corporation
>>>>
>>>> The Postgres Database Company
>>>>
>>>
>
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2020-08-03 08:06:09 [pgAdmin4][Patch] - SonarQube Fixes
Previous Message Akshay Joshi 2020-08-03 07:51:30 Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column