Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

Hi Rahul

Fixed the issue by modifying the condition from 'is false' to ' == false'.

On Fri, Jul 31, 2020 at 12:42 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> A syntactical error in a jinja template caught yesterday in Yogesh's local
> setup of pgAdmin by running a test suite for the changes done in this RM.
> It's strange going through several testings, even on Jenkins, it passed but
> failed on Yogesh's machine.
>
> I have made changes for this issue and rechecked with Yogesh, which seems
> to be fixed now.
>
> Could you please apply these relevant changes for this RM?
>
> On Wed, Jul 29, 2020 at 6:31 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Ignore the previous patch. Find below the rebased patch.
>>>
>>> On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat <
>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the patch below which fixes the issue of Start value while
>>>> updating the identity column.
>>>>
>>>> *Some additional issues were also found during development, which are
>>>> too fixed now :*
>>>>
>>>>
>>>> 1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence
>>>> options, it only updates identity* - *Fixed*
>>>> 2. *Cycled option issue - **Fixed*
>>>> Steps to reproduce :
>>>> - Update cycled to Yes, save it.
>>>> - Now change it to No, trying saving, gives error.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*