Fixed crash in debugger with wxWidget 3.0

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fixed crash in debugger with wxWidget 3.0
Date: 2014-05-23 13:05:48
Message-ID: CANxoLDfeVy=jPG_a833Kb2Xh=9oJ9LmDYA3T5iC2a+ZBZt6-dg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

During testing of pgAdmin3 with wxWidget 3.0, I have found one crash in
debugger. Cause of the crash is "m_progress" variable is not instantiated
before the function call "wxStatusBar::SetFieldsCount(fields);" at line no
49 in ctlProgressStatusBar.cpp.

Function call "wxStatusBar::SetFieldsCount(fields)" internally calls "
ctlProgressStatusBar::SetStatusWidths" which internally calls "
ctlProgressStatusBar::OnSize" and that time "m_progress" variable is
not instantiated, but used that's why application got crashed.

I have just moved up the call to instantiate the "m_progress" variable.
Attached is the patch file to fix the issue. Please review it and if it
looks good to you then can you please commit the code.

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
Fixed_Debugger_Crash.patch application/octet-stream 585 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-05-28 10:01:17 pgAdmin III commit: Fix a crash bug in the config editor.
Previous Message Ashesh Vashi 2014-05-23 09:31:33 PATCH: wxWidgets 3.0 Data dir