From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixed crash in debugger with wxWidget 3.0 |
Date: | 2014-05-28 10:50:44 |
Message-ID: | CA+OCxoxBr5HheSeG+=U0_2MXtys2xfkooe5FbQb-Ob0-Jk37+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - applied.
On Fri, May 23, 2014 at 9:05 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Dave
>
> During testing of pgAdmin3 with wxWidget 3.0, I have found one crash in
> debugger. Cause of the crash is "m_progress" variable is not instantiated
> before the function call "wxStatusBar::SetFieldsCount(fields);" at line
> no 49 in ctlProgressStatusBar.cpp.
>
> Function call "wxStatusBar::SetFieldsCount(fields)" internally calls "
> ctlProgressStatusBar::SetStatusWidths" which internally calls "
> ctlProgressStatusBar::OnSize" and that time "m_progress" variable is
> not instantiated, but used that's why application got crashed.
>
> I have just moved up the call to instantiate the "m_progress" variable.
> Attached is the patch file to fix the issue. Please review it and if it
> looks good to you then can you please commit the code.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517> Mobile: +91 976-788-8246
> <%2B91%20976-788-8246>*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2014-05-28 10:57:43 | pgAdmin III commit: Correctly initialise the datadir variable when usin |
Previous Message | Dave Page | 2014-05-28 10:50:18 | pgAdmin III commit: Fix a potential crash in the debugger. |