Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explain plan as JPEG/SVG format

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3589 Allow user to save/download Explain plan as JPEG/SVG format
Date: 2018-12-06 06:51:05
Message-ID: CANxoLDfaasCdWRYfCo_njnt+8DXSjy4+U_zfDyaWhi4k6hcFFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers

I didn't find the solution to show embedded SVG in Internet Explorer, so I
have disabled the "Download" button for Internet Explorer. Added new
function to get the browser name and version.

Attached is the modified patch, please review it.

On Mon, Dec 3, 2018 at 6:39 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> I am currently working on Feature 3589 "Allow user to save/download
> Explain plan as JPEG/SVG format." I have added one download button to the
> toolbar in "Explain" tab, when clicked it will download the explain plan as
> a SVG file.
>
> To add this feature I'll have to modify the logic, so instead of providing
> relative path of each plan (svg image), I have embedded the binary data
> which is required to download the Explain plan.
>
> I have tested it on following:
>
> - *Chrome* (Working Fine)
> - *FireFox* (Working Fine)
> - *Microsoft Edge* (Working Fine)
> - *Safari 10.1 and above. *'Download' attribute support is added in
> 10.1
> https://developer.apple.com/library/archive/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html
> - *Internet Explorer *(Images are not rendered, shown X icon.). Please
> refer attached image.
>
> Attached is the working patch for the above except Internet Explorer. I
> have tried a lot to figure out the solution, but unable to fix the issue. *Need
> help/suggestions how to fix the issue on Internet Explorer. *
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
RM_3589_v2.patch application/octet-stream 711.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-12-06 08:35:01 [pgAdmin4][Patch]: RM #3798 Unable to launch query tool window through Browser if user select any language except English under preferences section
Previous Message Khushboo Vashi 2018-12-06 05:43:21 Re: Build failed in Jenkins: pgadmin4-master-python27 #825