From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347 |
Date: | 2018-08-22 06:55:00 |
Message-ID: | CANxoLDfSC4BSdbE5kNAs2W_R0wmjY0NJnv17Lj25ySu+GesjOQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Aug 21, 2018 at 4:23 PM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Akshay,
>
> In restore, if I focus on "No of Jobs" and then click restore, I get an
> error as "object of type 'bool' has no len()" (looks like an existing issue)
> Apart from this, all looks good to me. Test cases run successfully.
>
Thanks fixed and committed the code.
>
>
>
>
> On Tue, Aug 21, 2018 at 12:15 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fixed following:
>>
>> - Feature #3503 Support PG utilities new options.
>> - RM #3347 schema / data only backup feature does not work as
>> expected.
>> - Added supported "Dump Options" for "*pg_dumpall*" which was not
>> there since pgAdmin 3.
>> - Fixed issue where "*--clean*" is not worked with "*--data-only*",
>> added validation.
>> - Fixed issue where "*--oids*" is not worked with "*--inserts*" and "
>> *--column-inserts*",added validation.
>>
>> Please review it.
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2018-08-22 09:43:57 | pgAdmin 4 commit: Ensure 'select all' and 'unselect all' working proper |
Previous Message | Akshay Joshi | 2018-08-22 06:54:18 | pgAdmin 4 commit: 1. Added new backup/restore options for PostgreSQL 11 |