Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347
Date: 2018-08-21 10:53:59
Message-ID: CAM9w-_nNBnMPbupemr1DjVGG_RVfPbUbuQ_xMfMK5rw5mvo4gQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

In restore, if I focus on "No of Jobs" and then click restore, I get an
error as "object of type 'bool' has no len()" (looks like an existing issue)
Apart from this, all looks good to me. Test cases run successfully.

On Tue, Aug 21, 2018 at 12:15 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to fixed following:
>
> - Feature #3503 Support PG utilities new options.
> - RM #3347 schema / data only backup feature does not work as expected.
> - Added supported "Dump Options" for "*pg_dumpall*" which was not
> there since pgAdmin 3.
> - Fixed issue where "*--clean*" is not worked with "*--data-only*",
> added validation.
> - Fixed issue where "*--oids*" is not worked with "*--inserts*" and "
> *--column-inserts*",added validation.
>
> Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-08-21 12:10:14 pgAdmin 4 commit: Stabilise feature tests for continuous running on CI
Previous Message Murtuza Zabuawala 2018-08-21 09:57:15 [pgAdmin4][RM #3313] "Select All" & "Unselect All" not working in Select2 control