| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
| Date: | 2020-09-22 09:26:29 |
| Message-ID: | CANxoLDfP08OdaHLPjM8uyUoGuYGwi7fCR3sa9rJTMb+jAnTqAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Aditya
The patch fixes only 1 code smell and introduce 1 new. Please fix those and
resend the patch.
On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py
> 40 to 15; 43 to 15
>
> Please review.
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2020-09-22 11:18:26 | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
| Previous Message | Nikhil Mohite | 2020-09-22 07:14:31 | Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions |