| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |
| Date: | 2020-09-22 11:18:26 |
| Message-ID: | CAM9w-_mJ=4pOPrXcv+1_e8G=bd7UCZ9OoV=p0PposQcLfF76eQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Please find the updated patch.
On Tue, Sep 22, 2020 at 2:56 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Aditya
>
> The patch fixes only 1 code smell and introduce 1 new. Please fix those
> and resend the patch.
>
> On Tue, Sep 22, 2020 at 11:04 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py
>> 40 to 15; 43 to 15
>>
>> Please review.
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
| Attachment | Content-Type | Size |
|---|---|---|
| sonarqube.filemanagerv2.patch | application/octet-stream | 15.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-09-22 11:19:19 | pgAdmin 4 commit: Fixed an issue where the server is not able to connec |
| Previous Message | Akshay Joshi | 2020-09-22 09:26:29 | Re: [pgAdmin][SonarQube] Reduce cognitive complexity |