From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixed database statistics report issue |
Date: | 2013-11-25 06:24:51 |
Message-ID: | CANxoLDfE8z72Bb9g45LFDdTMDTBv=2DL22_7DE1Fr6KGdGYbqg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Nov 22, 2013 at 8:51 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
>
> On Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>>
>> I have fixed one issue where Database statistics table goes beyond the
>> page headers. Below is the steps to reproduce it
>>
>> 1. Connect to database server.
>> 2. Right click on "Databases" root node.
>> 3. Choose Reports->Statistics Report.
>> 4. And give any location for that report.
>> 5. Then it's showing the statistics tables as like the attached
>> screenshot.
>>
>> Attached is the patch file to fix the issue, also attached the screenshot
>> of the report after fixing the issue. Can you please review it. If fix
>> looks good to you then can you please commit it.
>>
>
> Can you please fix:
>
> - The indenting, so that the contents of the new div are properly indented
> (as you've added a level to the document hierarchy).
>
> - The default-xsl.rst file in the docs, so it matches the new default.
>
> Otherwise, I think it looks fine. Thanks!
>
Done. Attached is the modified patch.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
Database_Statistics_Report_v1.patch | application/octet-stream | 4.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2013-11-25 09:00:02 | pgAdmin III commit: Ensure reports overflow the page width properly |
Previous Message | Dave Page | 2013-11-22 15:21:53 | Re: Fixed database statistics report issue |