Re: Fixed database statistics report issue

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed database statistics report issue
Date: 2013-11-22 15:21:53
Message-ID: CA+OCxowamiGYG+HYQOBf+h3K1YGMZy-z-snPUq7vAo=8iHWLCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Dave
>
> I have fixed one issue where Database statistics table goes beyond the
> page headers. Below is the steps to reproduce it
>
> 1. Connect to database server.
> 2. Right click on "Databases" root node.
> 3. Choose Reports->Statistics Report.
> 4. And give any location for that report.
> 5. Then it's showing the statistics tables as like the attached screenshot.
>
> Attached is the patch file to fix the issue, also attached the screenshot
> of the report after fixing the issue. Can you please review it. If fix
> looks good to you then can you please commit it.
>

Can you please fix:

- The indenting, so that the contents of the new div are properly indented
(as you've added a level to the document hierarchy).

- The default-xsl.rst file in the docs, so it matches the new default.

Otherwise, I think it looks fine. Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2013-11-25 06:24:51 Re: Fixed database statistics report issue
Previous Message Akshay Joshi 2013-11-22 11:18:25 Fixed database statistics report issue