From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5516]: Added support of Row Security Policies |
Date: | 2020-06-15 10:18:24 |
Message-ID: | CANxoLDfBYPQ63AfCD=vbhwz4GLmY4a_pdOMa0YcUa1BU7bT5qQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied with the following modifications:
- js file name should be "row_security_policy.js" instead of
"row_security_policies.js".
- Node name should be "row_security_policy" instead of
"row_level_policies". Node name should not be pluralized and it matches the
folder name.
- Icon name should be "coll-row_security_policy.svg" and
"row_security_policy.svg", it should matches with the Node name.
- The 'Owner' should be renamed to 'Role' and there must be a role 'public'
in the drop-down list. If the user does not provide any role then by
default it is public.
- Keywords like select, where, As should be in upper case in Jinja template.
- The policy node is disappeared when updating any value. Fixed that issue.
- There is no icon showing after creating the RLS node.
On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the attached patch for the 'Row Level Security' feature.
> I have added RE-SQL and API test cases also.
>
> To run the RE-SQL cases -
>
> - python runtests.py --pkg resql --modules row_security_policies.
>
> To run the API cases -
>
> - python runtests.py --pkg
> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2020-06-15 10:22:18 | Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables |
Previous Message | Akshay Joshi | 2020-06-15 10:15:11 | pgAdmin 4 commit: Added support of Row Security Policies. Fixes #5516 |