Re: [pgAdmin][RM5516]: Added support of Row Security Policies

From: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5516]: Added support of Row Security Policies
Date: 2020-06-22 09:53:18
Message-ID: CAJ9T6SvDfb16mTapggxw1tEt-Q4KnGnG_x9ct6vg9xYj7=1VWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Please find the updated patch. I have added a new RLS policy event 'ALL'.

On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied with the following modifications:
>
>
> - js file name should be "row_security_policy.js" instead of
> "row_security_policies.js".
> - Node name should be "row_security_policy" instead of
> "row_level_policies". Node name should not be pluralized and it matches the
> folder name.
> - Icon name should be "coll-row_security_policy.svg" and
> "row_security_policy.svg", it should matches with the Node name.
> - The 'Owner' should be renamed to 'Role' and there must be
> a role 'public' in the drop-down list. If the user does not provide any
> role then by default it is public.
> - Keywords like select, where, As should be in upper case in Jinja
> template.
> - The policy node is disappeared when updating any value. Fixed that
> issue.
> - There is no icon showing after creating the RLS node.
>
>
>
> On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for the 'Row Level Security' feature.
>> I have added RE-SQL and API test cases also.
>>
>> To run the RE-SQL cases -
>>
>> - python runtests.py --pkg resql --modules row_security_policies.
>>
>> To run the API cases -
>>
>> - python runtests.py --pkg
>> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation

Attachment Content-Type Size
cld-5516_v2.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yogesh Mahajan 2020-06-22 11:05:56 [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)
Previous Message Yogesh Mahajan 2020-06-22 09:27:58 [pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error