From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Alessandro De Maria <alessandro(dot)demaria(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Feature 6270: Allow for --load-servers to replace current server list |
Date: | 2021-03-01 12:30:59 |
Message-ID: | CANxoLDf7wtn9wn39sAKM012f+fkdZb2Tim9sDA23=+mxeKVobA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Mar 1, 2021 at 4:42 PM Alessandro De Maria <
alessandro(dot)demaria(at)gmail(dot)com> wrote:
> Hey Akshay,
>
> Thank you for the suggestions, here are the patches.
>
> Regards
> Alessandro
>
> On Fri, 26 Feb 2021 at 09:25, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Alessandro
>>
>> Patch looks good to me. Please fix the following issues:
>>
>> - Fix the PEP8 issue.
>> - Documentation needs to be updated with this new flag. Please update
>> "docs-> en_Us -> import_export_servers.rst" file.
>>
>>
>> On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
>> alessandro(dot)demaria(at)gmail(dot)com> wrote:
>>
>>> Hello,
>>>
>>> I have created a patch for the issue I raised earlier:
>>>
>>> https://redmine.postgresql.org/issues/6270
>>>
>>> I apologise I have never sent git patches before, and I could not find
>>> any specific documentation of how you expect to receive contributions.
>>>
>>> Regards
>>> Alessandro
>>>
>>> --
>>> Alessandro De Maria
>>> alessandro(dot)demaria(at)gmail(dot)com
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Alessandro De Maria
> alessandro(dot)demaria(at)gmail(dot)com
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | gmail Vladimir Koković | 2021-03-01 15:24:57 | pgAdmin 4 - desktop version - RPM |
Previous Message | Akshay Joshi | 2021-03-01 12:30:46 | Re: [pgAdmin]: Patch for SonarQube fixes. |