| From: | Alessandro De Maria <alessandro(dot)demaria(at)gmail(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature 6270: Allow for --load-servers to replace current server list |
| Date: | 2021-03-01 11:12:40 |
| Message-ID: | CAAivwfKkRbMuesLJnALGtJNLSZM=-OxgYZB87pebHrLzf2HYoQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hey Akshay,
Thank you for the suggestions, here are the patches.
Regards
Alessandro
On Fri, 26 Feb 2021 at 09:25, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Alessandro
>
> Patch looks good to me. Please fix the following issues:
>
> - Fix the PEP8 issue.
> - Documentation needs to be updated with this new flag. Please update
> "docs-> en_Us -> import_export_servers.rst" file.
>
>
> On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
> alessandro(dot)demaria(at)gmail(dot)com> wrote:
>
>> Hello,
>>
>> I have created a patch for the issue I raised earlier:
>>
>> https://redmine.postgresql.org/issues/6270
>>
>> I apologise I have never sent git patches before, and I could not find
>> any specific documentation of how you expect to receive contributions.
>>
>> Regards
>> Alessandro
>>
>> --
>> Alessandro De Maria
>> alessandro(dot)demaria(at)gmail(dot)com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Alessandro De Maria
alessandro(dot)demaria(at)gmail(dot)com
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Address-comments-on-pep8-and-documentation.patch | application/octet-stream | 2.8 KB |
| 0001-6270-add-replace-flag.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-03-01 12:30:14 | pgAdmin 4 commit: Fixed SonarQube issues. |
| Previous Message | Nikhil Mohite | 2021-03-01 11:12:39 | Re: [pgAdmin]: Patch for SonarQube fixes. |