Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze
Date: 2021-01-12 11:15:35
Message-ID: CANxoLDf7HmHSLePRbnfgU3=pt4KmZnAdsVdiUBhC2pBe7_W9aw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Attached is the updated patch. Please review.
>
> On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> Code looks good to me. Below are the review comments:
>>
>> - Copy and Paste not working in the popup.
>> - Documentation needs to be updated.
>>
>>
>> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch improves the way explain plan details tooltip for a node
>>> is shown. With the change, popup with details will be shown upon clicking a
>>> node, and it will remain open until explicitly closed.
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2021-01-12 11:55:55 [pgAdmin][RM-6075]: Non-admin user is unable to view shared server created using 'Service'.
Previous Message Akshay Joshi 2021-01-12 11:13:38 pgAdmin 4 commit: Improve the explain plan details by showing popup ins