From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze |
Date: | 2021-01-12 10:38:03 |
Message-ID: | CAM9w-_==zEUfHD63TpKbBAMUxNxLwOO01LtiNLSrT9M8oL-eDw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Attached is the updated patch. Please review.
On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Aditya
>
> Code looks good to me. Below are the review comments:
>
> - Copy and Paste not working in the popup.
> - Documentation needs to be updated.
>
>
> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch improves the way explain plan details tooltip for a node
>> is shown. With the change, popup with details will be shown upon clicking a
>> node, and it will remain open until explicitly closed.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM5488_v2.patch | application/octet-stream | 964.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-01-12 11:13:38 | pgAdmin 4 commit: Improve the explain plan details by showing popup ins |
Previous Message | Magnus Hagander | 2021-01-12 10:04:43 | Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1 |