Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables
Date: 2020-06-16 05:46:37
Message-ID: CANxoLDexDWFKP4NfdJY7cvUzn+jKJpnppoHjvwQ4MaaDE-KHeg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Jun 15, 2020 at 6:58 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Please find an updated patch.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Yogesh,
>>
>> this.data.splice is not required as you are adding the entire dataset into collection.
>>
>> Thanks,
>>
>> Khushboo
>>
>>
>> On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find attached patch fixing behaviour on checking select-all
>>> checkbox from properties tab for more than 50 entities.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-16 05:46:47 Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube
Previous Message Akshay Joshi 2020-06-16 05:46:26 Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions